Update the README and contribution guidelines to reflect the new development workflow#89
Merged
fdrozdowski merged 8 commits intodelphix:developfrom Mar 13, 2020
Merged
Conversation
fdrozdowski
changed the title
fdrozdowski
requested review from
ankursarin and
muralinimmagadda
as code owners
ankursarin
reviewed
Mar 10, 2020
ankursarin
reviewed
Mar 10, 2020
ankursarin
reviewed
Mar 10, 2020
ghost
previously approved these changes
Mar 10, 2020
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I only looked over the blackbox section, but LGTM!
fdrozdowski
changed the title
nhlien93
previously approved these changes
Mar 11, 2020
Contributor
nhlien93
left a comment
nhlien93
left a comment
There was a problem hiding this comment.
looks good, just a couple comments.
also just making sure, the last parts of the README-dev.md was just adding newlines right? I didn't see any world differences.
mothslaw
previously approved these changes
Mar 12, 2020
fdrozdowski
dismissed stale reviews from mothslaw, ravi-cm, and nhlien93
via
11a6ef7
jeffngo
previously approved these changes
Mar 12, 2020
ankursarin
reviewed
Mar 13, 2020
ankursarin
reviewed
Mar 13, 2020
ankursarin
reviewed
Mar 13, 2020
ankursarin
reviewed
Mar 13, 2020
ankursarin
reviewed
Mar 13, 2020
Comment on lines
+128
to
+138
| #### Blackbox tests targeting wrappers (mostly Delphix Engine workflows) | ||
| * appdata_python_samples (sample plugins from the app-gate): | ||
| `git blackbox -s appdata_python_samples --extra-params="-p virt-sdk-repo=https://github.com/<username>/virtualization-sdk.git -p virt-sdk-branch=my-feature"`, | ||
| * appdata_sanity with a direct Python plugin on CentOS 7.3: `git blackbox -s appdata_sanity -c APPDATA_PYTHON_DIRECT_CENTOS73 -a --extra-params="-p virt-sdk-repo=https://github.com/<username>/virtualization-sdk.git -p virt-sdk-branch=my-feature"`, | ||
| * appdata_sanity with a staged Python plugin on CentOS 7.3: `git blackbox -s appdata_sanity -c APPDATA_PYTHON_STAGED_CENTOS73 -a --extra-params="-p virt-sdk-repo=https://github.com/<username>/virtualization-sdk.git -p virt-sdk-branch=my-feature"`. | ||
|
|
||
| #### Blackbox tests targeting the CLI (~80% CLI tests) | ||
| * virtualization_sdk (installs and tests a direct Python plugin on Ubuntu 18): | ||
| `git blackbox -s virtualization_sdk -c APPDATA_SDK_UBUNTU18_DIRECT_CENTOS73 --extra-params="-p virt-sdk-repo=https://github.com/<username>/virtualization-sdk.git -p virt-sdk-branch=my-feature"`, | ||
| * virtualization_sdk (installs and tests a staged Python plugin on Ubuntu 18): | ||
| `git blackbox -s virtualization_sdk -c APPDATA_SDK_UBUNTU18_STAGED_CENTOS73 --extra-params="-p virt-sdk-repo=https://github.com/<username>/virtualization-sdk.git -p virt-sdk-branch=my-feature"`. No newline at end of file |
Contributor
There was a problem hiding this comment.
can we clarify what is the minimal set or "sanity" set that needs to be run as part of a PR, like have appdata_sanity as a single suite to run.
Contributor
Author
There was a problem hiding this comment.
I added the following to the Functional (blackbox) testing section:
"At minimum, each pull request should pass appdata_python_samples and appdata_sanity tests with a direct or staged plugin. See the section below for the description of each test suite."
nhlien93
approved these changes
Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The README was a little outdated, had mentions of the old Gradle build, and few errors.
What is the new behavior?
README-dev.md describes the new development workflow.
Does this introduce a breaking change?
Other information